Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll into view before moving pointer to make Firefox behave the same as Chrome #10

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

alexpott
Copy link
Collaborator

@alexpott
Copy link
Collaborator Author

If I run the test added on this issue without the fix it passes on chrome but fails on firefox.

It fails with the expected error.

1) Behat\Mink\Tests\Driver\Custom\LargePageClickTest::testLargePageClick
WebDriver\Exception\MoveTargetOutOfBounds: Move target (786, 19488) is out of bounds of viewport dimensions (1360, 888)

@longwave longwave merged commit 15c0c11 into Lullabot:main Jul 24, 2024
11 checks passed
@AlexSkrypnyk
Copy link

AlexSkrypnyk commented Aug 16, 2024

@longwave @alexpott
The addition of $this->scrollElementIntoView($element); broke multiple projects that have fixed top and bottom bars and where handling scrolling into view by themselves. This change reset that scrolling position and there is no way to preserve that position.

Is it possible to either revert this change or make it an opt-in/opt-out.

I'm happy to submit a PR if you could please let me know about the desired technical direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants